[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

classic Classic list List threaded Threaded
56 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

The problem is that I want to be able to create a new file in the same directory as the currenly editing file, and my workflow looks like this:
File - New
type stuff
"save as" and I want the FSB to already have the correct location I want.

Since i have the Console plugin also chdir-ing to the location of the currently open buffer, it changes into the wrong directory also.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 06, 2017 10:19 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by jedit-devel mailing list

ok I committed that and the change will be in the next daily build.
But we still need to fix the initial path issue.

as for leaving behind autosaves of untitled buffers, the user has 2 options.
1. uncheck autosave untitled buffers
2. set the autosave/backup directory to somewhere else.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 06, 2017 10:43 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

I created a patch, that works exactly as you described:

  • if the backup, autosave dir set:
  • new untitled buffers will be saved to that location
  • newly opened files will be autosaved to that dir, prefixed with their path

  • if the backup, autosave dir is NOT set:

  • new untitled buffers will be saved to the currently opened buffer's dir
    or for the very first start: to jedit's dir
  • newly opened files will be autosaved next to the original

Note: The autosave path will be set when a buffer is created/opened.
When we change the backup, autosave path from/to empty value, already opened buffers will preserve the path until jedit closed.

Fixed other problems like:
- press save for an untitled buffer saved without question
- after changing the autosave path, at next start the untitled buffer was not laoded.

Please test.

Attachments:


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 06, 2017 10:43 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

This is almost what I meant, so thank you for addressing my issues.

The one final thing I'd like changed is:
If backup, autosave dir is set:
new untitled buffers should go into the same place as if it is not set - same place as the currently opened buffer.
I don't want that setting to change jEdit's behavior when creating new untitled buffers.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Mon Jun 12, 2017 08:20 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

Be sure to update to 24708 because I made more changes to the code that you modified previously.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Mon Jun 12, 2017 08:20 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

It seems something else that has changed since jEdit 5.4 is the creation of a new untitled buffer when projectviewer changes projects (in the case where only project files were opened, and we have close open project files on project change, and also remember open files enabled).
There is a thread on jedit-users now subject: "Project Viewer opens an empty buffer"
I am not yet sure if it is your code or mine.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Mon Jun 12, 2017 08:20 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

I created a patch for "Project Viewer opens an empty buffer".
For some reason, I modified BufferSet.addBufferAt, but it can be reverted, and cured this problem.

For untitled backup: "when an autosave untitled is restored from backup", I need a little clarification. I do not see that any backup is saved for untitled buffers. Should we have backups also for untitled buffers?

And last:
me: if the backup, autosave dir set: new untitled buffers will be saved to that location
you: I don't want that setting to change jEdit's behavior when creating new untitled buffers.

Can we have an option like:
"Save untitled buffer to Autosave directory if Autosave directory is set" default off
with tooltip:
"When this option is checked, and the Autosave directory is set, save the untitled buffer to that directory.
Otherwise, it will be saved to the same place as the currently opened buffer (at the time when the untitled buffer was created)."

just for my sake? :-)

Attachments:


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 13, 2017 09:19 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

What i meant to say is "when an autosaved untitled is restored from the backup/autosave directory, its previous path should be restored, instead of the path to the autosave/backup location.

If you really want to add a checkbox, what would its name be?
"Don't store untitled autosaves in the autosave/backup directory" ?


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Fri Jun 16, 2017 07:19 AM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

Why would someone want untitled autosaves to be stored differently from regular autosaves?

Is having separate options for backup vs autosave directories more appropriate?


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Fri Jun 16, 2017 07:19 AM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

I had some misunderstanding of your wording lastly, but now I understand all requirements, and created the patch for that.
The only "big" change is that if no autosave/backup directory specified, the backup dir will be: jedit settings dir + backup, to separate those files.
Please test this patch.

Attachments:


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Fri Jun 16, 2017 03:43 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

I imagine some users will want autosaves/backups in the same directory, and others will not.

The current documentation and the feature requests I am trying to implement are trying to make both kinds of users happy.

If no autosave/backup is specified, it should use the same directory as the original file!

If an autosave/backup is specified, then the files are separate, and we can specify the location.

Why do you want to make things more complicated than that? And why do you want to hard-code the location of the default?


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 20, 2017 09:11 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

It sounds like the option you want is "location of new untitled buffers", regardless of autosave/backup dir.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 20, 2017 09:11 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by jedit-devel mailing list

I don't like this patch. You are adding a new field to the perspective when it is not necessary. Just save the correct location of the original UNTITLED buffer in the perspective, and then SEARCH for autosaves checking where getAutosaveDirectory() tells you to go for that buffer.
I don't like untitled buffers being autosaved in a different way from regular autosaves.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 20, 2017 09:11 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

Ok, from your perspective, what is left to be done for this feature to be accepted?


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Tue Jun 20, 2017 09:11 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

I just want to see the correct buffer path saved and restored from the perspective, untitled or not when autosave is used.
I recommend you make a feature request to describe what other thing you want.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Wed Jun 28, 2017 08:51 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

I think, now the code in trunk, restores the correct path. I tested it now.
We can forget my feature request.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Wed Jun 28, 2017 08:51 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

Trunk does not save the correct location of the untitled buffer to the perspective.
Instead it saves the location of the autosave.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Wed Jun 28, 2017 08:51 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by jedit-devel mailing list

Trunk does not save the correct location of the untitled buffer to the perspective.
Instead it saves the location of the backup/autosave directory, so the original untitled buffer path is lost.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Wed Jun 28, 2017 08:51 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list
In reply to this post by Hrotkó Gábor

I tested your requirement, and the full behavior is only possible with my patch: saveUntitled_24718.patch.
I tried to prepare another patch with less code modifications, but there is a problem: if you change the backup/autosave while creating untitled buffers, you cannot get the right paths back without storing it into the perspective.
Please try to create an untitled buffer, then restart, then change the backup/autosave path, then create another untitled buffer, then restart ...
That is why I created my patch that way.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Wed Jun 28, 2017 08:51 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

[ jEdit-devel ] [jedit:patches] Re: #596 #501 Auto-save untitled buffers - patch

jedit-devel mailing list

I think that when the autosave/backup directory is changed, it could popup a dialog that advises the user to restart jEdit to ensure all buffers are closed/opened again, to avoid old buffers autosaving to the wrong location. Your solution is only addressing untitled buffers.

Testing this latest patch, autosave untitleds are correctly restored but only when the autosave/backup directory is set. If it is left blank, the autosaves are stored in the wrong place - your default location instead of the untitled buffer's location.


[patches:#596] #501 Auto-save untitled buffers - patch

Status: pending-remind
Group:
Labels: untitled autosave
Created: Fri Feb 17, 2017 05:34 PM UTC by Hrotkó Gábor
Last Updated: Thu Jun 29, 2017 09:42 PM UTC
Owner: Alan Ezust
Attachments:

I created a patch for the feature request: "#501 Auto-save untitled buffers".
Altough the settings "Autosave untitled buffers" exists, but not working like described in the feature request.
My patch extends this feature, when "Autosave untitled buffers" checked (default):
- the untitled buffers will be autosaved when closing jedit, without a question prompt
- the autosave for an untitled buffer saved to <jedit_settings_dir>/autosave, and reloaded after a restart (the state persisted to the perspective.xml)
- closing an untitled buffer by hand removes the autosave file

Tested on windows7 and linux also.
The patch is against revision 24609.
Please review.
Thanks!


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/jedit/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
123