Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Jarekczek
Administrator
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:

> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> - <name>jEdit-FTP</name>
> + <name>FTP</name>
>   <comment></comment>
>   <projects>
>   </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>  
> @@ -155,7 +157,7 @@
>   finally
>   {
>   IOUtilities.closeQuietly(fis);
> - IOUtilities.closeQuietly(ois);
> + IOUtilities.closeQuietly((InputStream)ois);
>   }
>  
>   } //}}}
> @@ -191,7 +193,7 @@
>   }
>   finally
>   {
> - IOUtilities.closeQuietly(oos);
> + IOUtilities.closeQuietly((OutputStream)oos);
>   IOUtilities.closeQuietly(baos);
>   IOUtilities.closeQuietly(fos);
>   }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>  
> @@ -64,7 +66,7 @@
>   Log.log(Log.ERROR, DirectoryCache.class, e);
>   return null;
>   } finally {
> - IOUtilities.closeQuietly(in);
> + IOUtilities.closeQuietly((InputStream)in);
>   }
>   }
>   } //}}}
> @@ -106,7 +108,7 @@
>   }
>   finally
>   {
> - IOUtilities.closeQuietly(out);
> + IOUtilities.closeQuietly((OutputStream)out);
>   }
>   }
>   } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Alan Ezust-3
Administrator
How would you fix it in core?

On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Matthieu Casanova
Administrator
Now the Closeable interface exists and there is closeQuietly(Closeable) that does the job,
this method did not exist when I added closeQuietly(InputStream) and closeQuietly(OutputStream).
I think those two could be removed as InputStream and OutputStream both implements Closeable.
It would break binary compatibility of plugins that use them, but not source compatibility.

2012/10/11 Alan Ezust <[hidden email]>
How would you fix it in core?


On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel



------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Alan Ezust-3
Administrator
I think binary breakage might be worse than sourcecode breakage, because then it is harder to figure out which plugins are broken. I like removing extra methods we don't need which cause ambiguous function call errors though. but neither of our solutions solves Jarek's issue.


On Thu, Oct 11, 2012 at 8:03 AM, Matthieu Casanova <[hidden email]> wrote:
Now the Closeable interface exists and there is closeQuietly(Closeable) that does the job,
this method did not exist when I added closeQuietly(InputStream) and closeQuietly(OutputStream).
I think those two could be removed as InputStream and OutputStream both implements Closeable.
It would break binary compatibility of plugins that use them, but not source compatibility.


2012/10/11 Alan Ezust <[hidden email]>
How would you fix it in core?


On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel




------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Jarekczek
Administrator
In reply to this post by Matthieu Casanova
I don't think it's about Closeable which is labelled @since jEdit 4.3pre8. Methods with ObjectInput and ObjectOutput make collisions. The easiest fix is to remove these methods.

Jarek

W dniu 10/11/2012 05:03 PM, Matthieu Casanova pisze:
Now the Closeable interface exists and there is closeQuietly(Closeable) that does the job,
this method did not exist when I added closeQuietly(InputStream) and closeQuietly(OutputStream).
I think those two could be removed as InputStream and OutputStream both implements Closeable.
It would break binary compatibility of plugins that use them, but not source compatibility.

2012/10/11 Alan Ezust <[hidden email]>
How would you fix it in core?


On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel




------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Jarekczek
Administrator
In reply to this post by Alan Ezust-3
After reading more and thinking more I don't see a need to change anything. Now. Because a new plugin release is not necessary. Old plugin works thanks to binary compatibility. And current trunk plugin can be compiled against all jEdit versions, producing a jar compatible with all jEdit version. All right.

Jarek

W dniu 10/11/2012 04:39 PM, Alan Ezust pisze:
How would you fix it in core?

On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel



------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Reply | Threaded
Open this post in threaded view
|

Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[22345] plugins/FTP/trunk

Alan Ezust-3
Administrator
I think i have an even better idea. I will probably submit this as a patch or commit directly once I can resolve this other unit test fail error which seems to have nothing to do with what i am doing...

With this patch, we can address this with compiler warnings for one version and then remove the redundant methods later. We could merge this patch into 5.0.x and then remove the extra methods in 5.1. How does that sound?


On Thu, Oct 11, 2012 at 1:34 PM, Jarek Czekalski <[hidden email]> wrote:
After reading more and thinking more I don't see a need to change anything. Now. Because a new plugin release is not necessary. Old plugin works thanks to binary compatibility. And current trunk plugin can be compiled against all jEdit versions, producing a jar compatible with all jEdit version. All right.

Jarek

W dniu 10/11/2012 04:39 PM, Alan Ezust pisze:
How would you fix it in core?

On Thu, Oct 11, 2012 at 1:45 AM, Jarek Czekalski <[hidden email]> wrote:
If jEdit was fixed instead of the plugin, it would not require a new
plugin version release. Finding a person to release a plugin is a
difficulty. And what if this is not the only plugin to be fixed?

Since I do occasional plugin releases, it is somehow connected with me.

Jarek

W dniu 2012-10-11 03:14, [hidden email] pisze:
> Revision: 22345
>            http://jedit.svn.sourceforge.net/jedit/?rev=22345&view=rev
> Author:   ezust
> Date:     2012-10-11 01:14:07 +0000 (Thu, 11 Oct 2012)
> Log Message:
> -----------
> Resolved ambiguous method calls so it builds against 5.1pre1.
>
> Modified Paths:
> --------------
>      plugins/FTP/trunk/.project
>      plugins/FTP/trunk/ftp/ConnectionManager.java
>      plugins/FTP/trunk/ftp/DirectoryCache.java
>
> Modified: plugins/FTP/trunk/.project
> ===================================================================
> --- plugins/FTP/trunk/.project        2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/.project        2012-10-11 01:14:07 UTC (rev 22345)
> @@ -1,6 +1,6 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <projectDescription>
> -     <name>jEdit-FTP</name>
> +     <name>FTP</name>
>       <comment></comment>
>       <projects>
>       </projects>
>
> Modified: plugins/FTP/trunk/ftp/ConnectionManager.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/ConnectionManager.java      2012-10-11 01:14:07 UTC (rev 22345)
> @@ -31,8 +31,10 @@
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.ArrayList;
>   import java.util.HashMap;
>
> @@ -155,7 +157,7 @@
>               finally
>               {
>                       IOUtilities.closeQuietly(fis);
> -                     IOUtilities.closeQuietly(ois);
> +                     IOUtilities.closeQuietly((InputStream)ois);
>               }
>
>       } //}}}
> @@ -191,7 +193,7 @@
>               }
>               finally
>               {
> -                     IOUtilities.closeQuietly(oos);
> +                     IOUtilities.closeQuietly((OutputStream)oos);
>                       IOUtilities.closeQuietly(baos);
>                       IOUtilities.closeQuietly(fos);
>               }
>
> Modified: plugins/FTP/trunk/ftp/DirectoryCache.java
> ===================================================================
> --- plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-10 09:57:41 UTC (rev 22344)
> +++ plugins/FTP/trunk/ftp/DirectoryCache.java 2012-10-11 01:14:07 UTC (rev 22345)
> @@ -27,8 +27,10 @@
>   import java.io.File;
>   import java.io.FileInputStream;
>   import java.io.FileOutputStream;
> +import java.io.InputStream;
>   import java.io.ObjectInputStream;
>   import java.io.ObjectOutputStream;
> +import java.io.OutputStream;
>   import java.util.Enumeration;
>   import java.util.Hashtable;
>
> @@ -64,7 +66,7 @@
>                               Log.log(Log.ERROR, DirectoryCache.class, e);
>                               return null;
>                       } finally {
> -                             IOUtilities.closeQuietly(in);
> +                             IOUtilities.closeQuietly((InputStream)in);
>                       }
>               }
>       } //}}}
> @@ -106,7 +108,7 @@
>                       }
>                       finally
>                       {
> -                             IOUtilities.closeQuietly(out);
> +                             IOUtilities.closeQuietly((OutputStream)out);
>                       }
>               }
>       } //}}}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> jEdit-CVS mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/jedit-cvs
>


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel




------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
--
-----------------------------------------------
jEdit Developers' List
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jedit-devel

deprecate.diff (41K) Download Attachment